I previously wrote a post about having a rendering variant holding an inline JavaScript one might need along adding some basic JS functionality into your components.
This is useful when you're early developing your pages and have no possibility or capacity of recompiling entire frontend and updating Creative Exchange package into your solution because of adding/changing few lines; however, given approach is not SEO-friendly as search engines penalize sites for excessive inline scripts and styles. So use it considering to be technical debt, that should be addressed prior to going to production.
The very minimal change one can do is to replace the inline script with a reference to that same script stored in Media Library - same that SXA does itself with themes. This blog post below reveals an approach:
Firstly, create a template:
Then reference given template IDs within Constants.cs
file:
using Sitecore.Data;
namespace Platform.Foundation.Variants.Pipelines.VariantFields.ScriptReferenceTag
{
public static partial class Constants
{
public static partial class RenderingVariants
{
public static partial class Templates
{
public static ID ScriptReferenceTag { get; } = new ID("{0EC036D7-384D-4CF6-AD1F-FE949E96126A}");
}
public static partial class Fields
{
public static class ScriptReferenceTag
{
public static ID ScriptMedia { get; } = new ID("{F1497AF9-7DD3-4B38-BE22-5F092007F929}");
}
}
}
}
}
Model class, having just one property that stores a GUID of a referenced script from Media Library using Sitecore.Data.Items;
using Sitecore.XA.Foundation.RenderingVariants.Fields;
namespace Platform.Foundation.Variants.Pipelines.VariantFields.ScriptReferenceTag
{
public class VariantScriptReferenceTag : RenderingVariantFieldBase
{
public string ScriptMedia { get; set; }
public VariantScriptReferenceTag(Item variantItem) : base(variantItem)
{
}
}
}
Parser:using Sitecore.Data;
using Sitecore.XA.Foundation.Variants.Abstractions.Pipelines.ParseVariantFields;
namespace Platform.Foundation.Variants.Pipelines.VariantFields.ScriptReferenceTag
{
public class ParseScriptReferenceTag : ParseVariantFieldProcessor
{
public override ID SupportedTemplateId => Constants.RenderingVariants.Templates.ScriptReferenceTag;
public override void TranslateField(ParseVariantFieldArgs args)
{
ParseVariantFieldArgs variantFieldArgs = args;
var variantHtmlTag = new VariantScriptReferenceTag(args.VariantItem) { Tag = "script" };
variantHtmlTag.ScriptMedia = args.VariantItem[Constants.RenderingVariants.Fields.ScriptReferenceTag.ScriptMedia];
variantFieldArgs.TranslatedField = variantHtmlTag;
}
}
}
Renderer:using System;
using Sitecore.Data;
using System.Web.UI.HtmlControls;
using Sitecore.XA.Foundation.RenderingVariants.Pipelines.RenderVariantField;
using Sitecore.XA.Foundation.Variants.Abstractions.Pipelines.RenderVariantField;
using Sitecore.Resources.Media;
namespace Platform.Foundation.Variants.Pipelines.VariantFields.ScriptReferenceTag
{
public class RenderScriptReferenceTag : RenderVariantField
{
public override Type SupportedType => typeof(VariantScriptReferenceTag);
public override void RenderField(RenderVariantFieldArgs args)
{
var variantField = args.VariantField as VariantScriptReferenceTag;
if (variantField != null)
{
var id = variantField?.ScriptMedia;
if (string.IsNullOrWhiteSpace(id))
{
return;
}
var scriptItem = Context.Database.GetItem(new ID(id));
if(scriptItem == null)
{
return;
}
var url = MediaManager.GetMediaUrl(scriptItem);
var tag = new HtmlGenericControl(variantField.Tag);
tag.Attributes.Add("type", "text/javascript");
tag.Attributes.Add("defer", String.Empty);
tag.Attributes.Add("src", url);
args.ResultControl = tag;
args.Result = RenderControl(args.ResultControl);
}
}
}
}
Example of usage:
This rendering variant field generates the following output:
<script src="/-/media/Project/Platform/Other/Scripts/Header-script.js" type="text/javascript" defer="" ></script>
This approach works perfectly well. But once again for a second, have you ever considered moving such scripts into a Theme along with related component (if any) instead of leaving it like that? Hope this helps!